ansible-lint recommendations

roles/webserver/tasks/nginx.yml

@@ -11,7 +11,7 @@
     - {src: "header.conf.j2", dest: "/etc/nginx/global/header.conf"}
     - {src: "proxy.conf.j2", dest: "/etc/nginx/global/proxy.conf"}
     - {src: "php_optimization.j2", dest: "/etc/nginx/global/php_optimization"}
-  notify: reload nginx
+  notify: Reload nginx
 
 - name: Copy virtual server configs
   template:
@@ -19,7 +19,7 @@
     dest: /etc/nginx/conf.d/{{ item | basename | regex_replace('\.j2$', '') }}
     mode: "0644"
   with_fileglob: "../templates/conf.d/*.j2"
-  notify: reload nginx
+  notify: Reload nginx
 
 ## Certificates
 
@@ -39,7 +39,7 @@
     group: root
     mode: "0600"
   loop: [crt, key, issuer.crt]
-  notify: reload nginx
+  notify: Reload nginx
 
 - name: Create nginx.service.d directory
   file:
@@ -52,4 +52,4 @@
     src: nginx_systemd.conf.j2
     dest: /etc/systemd/system/nginx.service.d/nginx.conf
     mode: "0644"
-  notify: restart nginx
+  notify: Restart nginx

roles/webserver/tasks/php.yml

@@ -9,7 +9,7 @@
     state: "{{ item.state | default('present') }}"
   loop: "{{ php_fpm_ini_options }}"
   when: '"fpm" in php_modules'
-  notify: restart php-fpm
+  notify: Restart php-fpm
 
 - name: Configure FPM pool
   lineinfile:
@@ -18,7 +18,7 @@
     line: '{{ item.option }} = {{ item.value }}'
   loop: "{{ php_fpm_pool_options }}"
   when: '"fpm" in php_modules'
-  notify: restart php-fpm
+  notify: Restart php-fpm
 
 - name: Configure FPM environment variables
   replace:
@@ -29,7 +29,7 @@
     - {regexp: ";env", replace: "env"}
     - {regexp: ";clear_env", replace: "clear_env"}
   when: '"fpm" in php_modules'
-  notify: restart php-fpm
+  notify: Restart php-fpm
 
 - name: Install imagemagick package
   apt:

roles/webserver/tasks/volume.yml

@@ -5,7 +5,7 @@
     api_token: "{{ vault_hcloud_token }}"
     name: "{{ hcloud_webserver_volume_name }}"
   delegate_to: localhost
-  register: web_hcloud_volume
+  register: webserver_hcloud_volume_info
 
 - name: Creates mount directory
   file:
@@ -16,7 +16,7 @@
 - name: Mount hcloud volume
   ansible.posix.mount:
     path: "{{ hcloud_webserver_volume_path }}"
-    src: "{{ web_hcloud_volume.hcloud_volume_info[0].linux_device }}"
+    src: "{{ webserver_hcloud_volume_info.hcloud_volume_info[0].linux_device }}"
     fstype: ext4
     opts: discard,nofail,defaults
     state: mounted