ansible-lint recommendations

roles/postgresql/handlers/main.yml

@@ -1,15 +1,15 @@
 ---
-- name: restart postgresql
+- name: Restart postgresql
   systemd:
     name: postgresql.service
     state: restarted
 
-- name: reload postgresql
+- name: Reload postgresql
   systemd:
     name: postgresql.service
     state: reloaded
 
-- name: restart postgres_exporter
+- name: Restart postgres_exporter
   systemd:
     daemon_reload: true
     enabled: true

roles/postgresql/tasks/postgres_exporter.yml

@@ -20,8 +20,8 @@
           v{{ postgres_exporter_version.tag }}/postgres_exporter-{{ postgres_exporter_version.tag }}\
           .linux-{{ deb_architecture }}.tar.gz"
     dest: "/var/tmp/postgres_exporter.tar.gz"
-  register: _download_archive
-  until: _download_archive is succeeded
+  register: postgres_exporter_download_archive
+  until: postgres_exporter_download_archive is succeeded
   retries: 3
   delay: 5
 
@@ -36,7 +36,7 @@
       --strip-components=1
     include:
       - "postgres_exporter-{{ postgres_exporter_version.tag }}.linux-{{ deb_architecture }}/postgres_exporter"
-  notify: restart postgres_exporter
+  notify: Restart postgres_exporter
 
 - name: Copy the postgres_exporter systemd service file
   template:
@@ -45,4 +45,4 @@
     owner: root
     group: root
     mode: "0644"
-  notify: restart postgres_exporter
+  notify: Restart postgres_exporter

roles/postgresql/tasks/postgresql.yml

@@ -33,7 +33,7 @@
   become_user: postgres
   register: postgresql_set
   loop: "{{ pgsql_config }}"
-  notify: restart postgresql
+  notify: Restart postgresql
 
 - name: Set PostgreSQL Client Authentication
   community.postgresql.postgresql_pg_hba:
@@ -46,4 +46,4 @@
     contype: host
     # custom rules
     rules: "{{ pgsql_client_auth }}"
-  notify: reload postgresql
+  notify: Reload postgresql