ansible-lint recommendations

roles/nextcloud/tasks/configure.yml

@@ -54,16 +54,19 @@
           v{{ nextcloud_exporter_version.tag }}/nextcloud-exporter-{{ nextcloud_exporter_version.tag }}\
           -{{ deb_architecture }}.bz2"
     dest: "/var/tmp/nextcloud-exporter.bz2"
-  register: _download_archive
-  until: _download_archive is succeeded
+  register: nextcloud_exporter_download_archive
+  until: nextcloud_exporter_download_archive is succeeded
   retries: 3
   delay: 5
 
-- name: decompress nextcloud_exporter
+- name: Decompress nextcloud_exporter
   command:
     cmd: "bzip2 -dk nextcloud-exporter.bz2"
-    chdir: /var/tmp
-    creates: /var/tmp/nextcloud-exporter
+  args:
+    chdir: /var/tmp/
+  register: nextcloud_exporter_decompress_archive
+  changed_when: nextcloud_exporter_decompress_archive.rc != 0
+  when: nextcloud_exporter_download_archive.changed  # noqa: no-handler
 
 - name: Copy nextcloud_exporter
   copy:
@@ -73,7 +76,7 @@
     owner: "{{ nextcloud_exporter_system_user }}"
     group: "{{ nextcloud_exporter_system_group }}"
     mode: "0755"
-  notify: restart nextcloud_exporter
+  notify: Restart nextcloud_exporter
 
 - name: Get latest nextcloud_notify_push version
   github_release:
@@ -91,12 +94,12 @@
 
 - name: "set deb_architecture alias"
   set_fact:
-    deb_architecture_alias: "x86_64"
+    deb_architecture_alias: "x86_64"  # noqa: var-naming[no-role-prefix]
   when: deb_architecture == "amd64"
 
 - name: "set deb_architecture alias"
   set_fact:
-    deb_architecture_alias: "{{ deb_architecture }}"
+    deb_architecture_alias: "{{ deb_architecture }}"  # noqa: var-naming[no-role-prefix]
   when: deb_architecture != "amd64"
 
 - name: Download nextcloud_notify_push {{ nextcloud_notify_push_version.tag }} from GitHub
@@ -104,8 +107,8 @@
     url: "https://github.com/nextcloud/notify_push/releases/download/v{{ nextcloud_notify_push_version.tag }}\
           /notify_push-{{ deb_architecture_alias }}-unknown-linux-musl"
     dest: "/var/tmp/notify_push-{{ deb_architecture_alias }}-unknown-linux-musl"
-  register: _download_archive
-  until: _download_archive is succeeded
+  register: nextcloud_notify_push_download_archive
+  until: nextcloud_notify_push_download_archive is succeeded
   retries: 3
   delay: 5
 
@@ -117,7 +120,7 @@
     owner: "{{ webserver_user }}"
     group: "{{ webserver_group }}"
     mode: "0700"
-  notify: restart nextcloud_notify_push
+  notify: Restart nextcloud_notify_push
 
 - name: Copy nextcloud_nightlycron
   template:
@@ -142,8 +145,8 @@
     - nextcloud_nightlycron.service
     - nextcloud_nightlycron.timer
   notify:
-    - restart {{ item | regex_replace ('\..*', '') }}
-    - restart systemd_exporter
+    - Restart {{ item | regex_replace ('\..*', '') }}
+    - Restart systemd_exporter
 
 - name: Copy Nextcloud logrotate file
   template: