ansible-lint recommendations

roles/nextcloud/handlers/main.yml

@@ -1,13 +1,13 @@
 ---
 
-- name: restart rclone_mount_nextcloud
+- name: Restart rclone_mount_nextcloud
   systemd:
     daemon_reload: true
     enabled: true
     name: rclone_mount_nextcloud.service
     state: restarted
 
-- name: restart nextcloudcron
+- name: Restart nextcloudcron
   systemd:
     daemon_reload: true
     enabled: true
@@ -15,28 +15,28 @@
     state: restarted
   loop: [nextcloudcron.service, nextcloudcron.timer]
 
-- name: restart nextcloud_nightlycron
+- name: Restart nextcloud_nightlycron
   systemd:
     daemon_reload: true
     enabled: true
     name: nextcloud_nightlycron.timer
     state: restarted
 
-- name: restart nextcloud_notify_push
+- name: Restart nextcloud_notify_push
   systemd:
     daemon_reload: true
     enabled: true
     name: nextcloud_notify_push.service
     state: restarted
 
-- name: restart nextcloud_exporter
+- name: Restart nextcloud_exporter
   systemd:
     daemon_reload: true
     enabled: true
     name: nextcloud_exporter.service
     state: restarted
 
-- name: restart nextcloud_backup_timer
+- name: Restart nextcloud_backup_timer
   systemd:
     daemon_reload: true
     enabled: true

roles/nextcloud/tasks/configure.yml

@@ -54,16 +54,19 @@
           v{{ nextcloud_exporter_version.tag }}/nextcloud-exporter-{{ nextcloud_exporter_version.tag }}\
           -{{ deb_architecture }}.bz2"
     dest: "/var/tmp/nextcloud-exporter.bz2"
-  register: _download_archive
-  until: _download_archive is succeeded
+  register: nextcloud_exporter_download_archive
+  until: nextcloud_exporter_download_archive is succeeded
   retries: 3
   delay: 5
 
-- name: decompress nextcloud_exporter
+- name: Decompress nextcloud_exporter
   command:
     cmd: "bzip2 -dk nextcloud-exporter.bz2"
-    chdir: /var/tmp
-    creates: /var/tmp/nextcloud-exporter
+  args:
+    chdir: /var/tmp/
+  register: nextcloud_exporter_decompress_archive
+  changed_when: nextcloud_exporter_decompress_archive.rc != 0
+  when: nextcloud_exporter_download_archive.changed  # noqa: no-handler
 
 - name: Copy nextcloud_exporter
   copy:
@@ -73,7 +76,7 @@
     owner: "{{ nextcloud_exporter_system_user }}"
     group: "{{ nextcloud_exporter_system_group }}"
     mode: "0755"
-  notify: restart nextcloud_exporter
+  notify: Restart nextcloud_exporter
 
 - name: Get latest nextcloud_notify_push version
   github_release:
@@ -91,12 +94,12 @@
 
 - name: "set deb_architecture alias"
   set_fact:
-    deb_architecture_alias: "x86_64"
+    deb_architecture_alias: "x86_64"  # noqa: var-naming[no-role-prefix]
   when: deb_architecture == "amd64"
 
 - name: "set deb_architecture alias"
   set_fact:
-    deb_architecture_alias: "{{ deb_architecture }}"
+    deb_architecture_alias: "{{ deb_architecture }}"  # noqa: var-naming[no-role-prefix]
   when: deb_architecture != "amd64"
 
 - name: Download nextcloud_notify_push {{ nextcloud_notify_push_version.tag }} from GitHub
@@ -104,8 +107,8 @@
     url: "https://github.com/nextcloud/notify_push/releases/download/v{{ nextcloud_notify_push_version.tag }}\
           /notify_push-{{ deb_architecture_alias }}-unknown-linux-musl"
     dest: "/var/tmp/notify_push-{{ deb_architecture_alias }}-unknown-linux-musl"
-  register: _download_archive
-  until: _download_archive is succeeded
+  register: nextcloud_notify_push_download_archive
+  until: nextcloud_notify_push_download_archive is succeeded
   retries: 3
   delay: 5
 
@@ -117,7 +120,7 @@
     owner: "{{ webserver_user }}"
     group: "{{ webserver_group }}"
     mode: "0700"
-  notify: restart nextcloud_notify_push
+  notify: Restart nextcloud_notify_push
 
 - name: Copy nextcloud_nightlycron
   template:
@@ -142,8 +145,8 @@
     - nextcloud_nightlycron.service
     - nextcloud_nightlycron.timer
   notify:
-    - restart {{ item | regex_replace ('\..*', '') }}
-    - restart systemd_exporter
+    - Restart {{ item | regex_replace ('\..*', '') }}
+    - Restart systemd_exporter
 
 - name: Copy Nextcloud logrotate file
   template:

roles/nextcloud/tasks/dependencies.yml

@@ -16,7 +16,7 @@
   lineinfile:
     path: /etc/php/{{ php_version }}/cli/conf.d/20-apcu.ini
     line: apc.enable_cli=1
-  notify: restart php-fpm
+  notify: Restart php-fpm
 
 - name: "Add {{ webserver_user }} user to redis group"
   user:

roles/nextcloud/tasks/nextcloud.yml

@@ -1,5 +1,5 @@
 ---
-# flush handlers to restart code-server before install extensions
+# flush handlers to Restart code-server before install extensions
 - name: Flush handlers befor continue
   meta: flush_handlers
 
@@ -23,8 +23,8 @@
       get_url:
         url: "https://download.nextcloud.com/server/releases/latest.tar.bz2"
         dest: "/var/tmp/nextcloud.tar.gz"
-      register: _download_archive
-      until: _download_archive is succeeded
+      register: nextcloud_download_archive
+      until: nextcloud_download_archive is succeeded
       retries: 3
       delay: 5
 

roles/nextcloud/tasks/rclone.yml

@@ -21,7 +21,7 @@
     src: rclone_mount_nextcloud.service.j2
     dest: /etc/systemd/system/rclone_mount_nextcloud.service
     mode: "0640"
-  notify: restart rclone_mount_nextcloud
+  notify: Restart rclone_mount_nextcloud
 
 - name: "Add {{ webserver_user }} user to rclone group"
   user:

roles/nextcloud/templates/nextcloud.config.json.j2

@@ -25,8 +25,8 @@
         "mail_sendmailmode": "smtp",
         "mail_domain": "{{ nextcloud_smtp_from_domain }}",
         "mail_smtpauth": 1,
-        "mail_smtpname": "{{ nextcloud_smtp_user }}",
-        "mail_smtppassword": "{{ nextcloud_smtp_pass }}",
+        "mail_smtpname": "{{ vault_nextcloud_smtp_user }}",
+        "mail_smtppassword": "{{ vault_nextcloud_smtp_pass }}",
         "mail_smtpsecure": "tls",
         "loglevel": 1,
         "logfile": {{ nextcloud_log_file | to_json }},

roles/nextcloud/templates/rclone_mount_nextcloud.service.j2

@@ -13,8 +13,8 @@ ExecStart=/usr/bin/rclone mount DTSV_crypt:cloud_data {{ nextcloud_rclone_mount_
         --use-mmap \
         --default-permissions \
         --allow-other \
-        --uid {{ created_rclone_user.uid }} \
-        --gid {{ created_rclone_group.gid }} \
+        --uid {{ rclone_created_user.uid }} \
+        --gid {{ rclone_created_group.gid }} \
         --umask 0007 \
         --dir-perms 0770 \
         --file-perms 0660 \

roles/nextcloud/vars/main.yml

@@ -43,14 +43,14 @@ nextcloud_smtp_host: "{{ smtp_hostname }}"
 nextcloud_smtp_port: "{{ smtp_port }}"
 nextcloud_smtp_from_address: "cloud"
 nextcloud_smtp_from_domain: "twirling.de"
-nextcloud_smtp_user: !vault |
+vault_nextcloud_smtp_user: !vault |
   $ANSIBLE_VAULT;1.2;AES256;dtsv-dev
   37323762356630343133346634653965303530363966646236383962313163623637326165346439
   3234303935353134633238396365363036313363663031310a663339363665376564306565393538
   33663566663534383133623965316362383731303565326632623430303565343134393939343734
   3930376165653536310a656632373336623663356431333136303165653162333137626632333033
   35363439346237666662333537613363386266653865656238323638666533356535
-nextcloud_smtp_pass: !vault |
+vault_nextcloud_smtp_pass: !vault |
   $ANSIBLE_VAULT;1.2;AES256;dtsv-dev
   61303737376466646164313766373639376133633935313433356637323038626437663736363631
   3864616433353737666137663663666333366463626337630a643034323935613833633439306236